Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve absolute path for admin console. #4024

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

Thisara-Welmilla
Copy link

@Thisara-Welmilla Thisara-Welmilla commented Jul 3, 2024

Issue:

Improve code based to absolute Urls for Admin Management Console, if the AdminConsole.ResolveAbsoluteURLs.Enable config is enabled.

Config can be enabled/diasbled adding following config to the deployment.toml

[admin_console.resolve_absolute_urls]
enable = true

@Thisara-Welmilla Thisara-Welmilla force-pushed the resolve-absolute-path branch 3 times, most recently from 8f701f5 to 25393af Compare July 3, 2024 12:26
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/9777943733

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9777943733
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9777943733

chamathns
chamathns previously approved these changes Jul 4, 2024
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/9951672440

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9951672440
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9951672440

@wso2 wso2 deleted a comment from jenkins-is-staging Jul 16, 2024
@wso2 wso2 deleted a comment from jenkins-is-staging Jul 16, 2024
@wso2 wso2 deleted a comment from jenkins-is-staging Jul 16, 2024
@wso2 wso2 deleted a comment from jenkins-is-staging Jul 16, 2024
@wso2 wso2 deleted a comment from jenkins-is-staging Jul 16, 2024
@wso2 wso2 deleted a comment from jenkins-is-staging Jul 16, 2024
@wso2 wso2 deleted a comment from jenkins-is-staging Jul 16, 2024
@wso2 wso2 deleted a comment from jenkins-is-staging Jul 16, 2024
@Thisara-Welmilla Thisara-Welmilla merged commit 8ae2e27 into wso2:4.10.x Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants